Conversation
…hub.com/anlowee/clp-bench into xiaochong-add-mongodb-benchmark-toolset
…actors are needed
|
Sorry, won't be able to review this until tonight. |
|
Sorry, was sick over the weekend so didn't get a chance to look at this. Will review at least the docs today. |
Take care! It becomes very vold suddenly these days. |
kirkrodrigues
left a comment
kirkrodrigues
left a comment
There was a problem hiding this comment.
Some feedback on the docs. I would also like to clean up the directory structure, but I guess that may take you some time, so we can defer it to the next PR.
kirkrodrigues
left a comment
kirkrodrigues
left a comment
There was a problem hiding this comment.
Some additional comments besides those inline:
- For all Markdown link references (i.e., the
bin[a][b]):- can we avoid using spaces?
- can we keep them short (that's the goal of using link references)?
Thanks for making the changes requested so far. To give you some context, my goal is that we get this PR to a state where the docs and usage are clear. Then we can defer any additional refactoring to future PRs.
|
Sorry, need a little more time to finish reviewing this. |
|
Is the first flowchart in the methodology being displayed as you expect? |
Apparently no lol, so weird. It should look like this: Don't know why it gets rendered so weirdly on github |
Fixed this in the latest commit |
2 participants
This PR does a major refactoring. The main change is that we lock the clp-bench executor's code logic, for each target tool, the user shall provide corresponding scripts that to execute tasks of benchmarking.
Benefits: